[8.x](backport #7456) Support replace directives in otel readme mage command#7616
Merged
[8.x](backport #7456) Support replace directives in otel readme mage command#7616
Conversation
mergify
bot
added
backport
conflicts
mergify
bot
requested review from
michel-laterman and
ycombinator
and removed request for
a team
Contributor
Author
|
Cherry-pick of 9071254 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
* Support pseudo-versions in otel readme mage command * Move otel dependency handling to a separate package (cherry picked from commit 9071254) # Conflicts: # go.mod
swiatekm
force-pushed
the
mergify/bp/8.x/pr-7456
branch
from
5afe15c to
4a77955
Compare
swiatekm
approved these changes
Mar 28, 2025
|
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the
otel:readmemage command support replace directives. It now also supports pseudo-versions that Go uses for commit hashes in go.mod.The implementation now actually parses the go.mod file using x/mod.
Why is it important?
In order to resolve a dependency conflict between beats and otel 0.120.x, we're going to use our own fork of prometheusreceiver. See #7443 for this change made in the 8.18 branch.
Checklist
This is an automatic backport of pull request #7456 done by [Mergify](https://mergify.com).